chore: 重複した checksum 改ざんテストを統合（#43）#52
Merged
Merged
Conversation
tests/checksum-tamper.test.ts は checksum.test.ts の `tamper detection` describe と完全に同一だったため削除。 parse / sha256File / verifyChecksum の単体 + tamper 統合は checksum.test.ts 側に集約済み（§10.3）。 Closes #43 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AECzAv2vcdATecuvLjBSa6
- #43 を解決済みへ移動 - §10.3 のテスト参照を glob から単一ファイル（checksum.test.ts）へ Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AECzAv2vcdATecuvLjBSa6
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesTODO.md 更新
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
tests/checksum-tamper.test.tsがtests/checksum.test.ts内のtamper detectiondescribe と完全に同一だったため、重複を解消する（#43）。変更内容
tests/checksum-tamper.test.tsを削除checksum.test.tsのfetchChecksum + verifyChecksum: tamper detectiondescribe と ASSET・payload・stub helper まで一致checksum.test.tsに集約済み（要求仕様書 §10.3）TODO.mdchecksum*.test.ts）から単一ファイル（checksum.test.ts）へ検証
pnpm run all✅（typecheck / lint / 47 tests / build）self-test.ymlのコメントは残す側checksum.test.tsを参照）参照
🤖 Generated with Claude Code
Summary by cubic
Removed the duplicate checksum tamper tests and consolidated all coverage into
tests/checksum.test.tsto simplify maintenance and keep §10.3 tests in one place. Closes #43.tests/checksum-tamper.test.ts; its three scenarios are already covered intests/checksum.test.ts.TODO.mdto point §10.3 totests/checksum.test.tsand moved [chore] checksum 改ざんテストの重複ファイルを統合 #43 to resolved.Written for commit fd364dc. Summary will update on new commits.